en/enBoxer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

toplevel_export: capture_via_export docstring contradiction (Grok round 3 #11)

Browse Source 
The docstring simultaneously claimed the function writes a synthetic
PNG-sized byte slice and that a real pixel read runs end-to-end via
gbm_runtime. Rewritten to be consistent with what the function
actually does today: real RGBA8 pixel read via gbm_runtime on
success, synthetic-frame fallback on any libgbm/format failure.

cargo test 99+/0; clippy clean.
This commit is contained in:
en 2026-09-16 17:33:25 +02:00
parent 0906e86594
commit 60385d062a
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/toplevel_export.rs
View File

@ -218,14 +218,12 @@ pub async fn capture_via_export_for(
capture_with_state(conn, manager, output, dest, event_queue).await capture_with_state(conn, manager, output, dest, event_queue).await
} }
/// Public entry: the dmabuf path of `capture_toplevel`. Connects to /// Public entry: the dmabuf path of capture_toplevel. Connects to
/// Wayland, requests an export against the requested output, waits for /// Wayland, requests an export against the requested output, waits for
/// the `frame` + per-plane `object` + `ready` events, then **without** /// the frame + per-plane object + ready events, then writes real RGBA8
/// calling gbm writes a synthetic PNG-sized byte slice to `dest`. The /// pixels to dest via gbm_runtime (Bug #9 closed; commit 0ba3c59).
/// synthetic frame proves the protocol round-trip end-to-end; a real /// On any libgbm/format failure the synthetic-frame fallback runs so
/// pixel read runs end-to-end via `crate::gbm_runtime` (Bug #9 /// the caller always sees the round-trip metadata.
/// closed; commit `0ba3c59`). On any libgbm/format failure the
/// synthetic-frame fallback runs.
pub async fn capture_via_export( pub async fn capture_via_export(
output: &wl_output::WlOutput, output: &wl_output::WlOutput,
dest: &Path, dest: &Path,