Grok round 5 found:
1. examples/games.yaml was actually src/main.rs (227 lines of clap
CLI; my round-4 Item 4 commit message was wrong). Replaced with
a real seed YAML. The example shows the env format as
[[KEY, VALUE], ...] (a list of pairs), NOT KEY=*** (serde_yaml
will not parse KEY=*** into Vec<(String, String)>).
3. App.pending_ipc was written by Free-mode buttons but never
drained by the main loop. Replaced with direct self.ipc(...)
calls. Hoisted the closure borrow by collecting verbs into a
Vec<(&str, u32)> and draining after the slots borrow is
released. Dropped the pending_ipc field + App literal init.
8. Doc residue: passthrough / window_match claims still in
README.md, CHANGELOG.md, docs/DESIGN.md. Updated README.md to
point at round-4 Item 6 + Item 3. Added a round-4 section at
the top of CHANGELOG.md. Dropped the duplicate passthrough
bullet in docs/DESIGN.md.
10. Dead passthrough_id helper in hotkey.rs (unused after the
passthrough feature dropped in round-4 Item 6). Dropped the
function + its doc comment.
cargo test 103/103; clippy clean.
Master: "idk why you have a Teams/Lutris section. When I am under
session I should be able to select a list of games so you know how to
launch the correct game, currently you lack that list and drop down
option."
Implementation:
- src/games.rs (new module):
* Game struct: { name, exe, args, env, cwd, note }.
* load_all(path) -> Vec<Game>; returns empty list when the file
does not exist (operator has not configured any games yet).
* find(games, name) -> Option<Game> (case-sensitive, O(n)).
* save_all(path, games) for the GUI Add-Game form.
* default_path() -> ~/.config/enboxer/games.yaml.
* Three unit tests (load_missing empty, find_by_name, YAML roundtrip).
- src/lib.rs: pub mod games registered.
- src/session.rs:
* New IPC verb "launch-game NAME": spawns the picked game entry,
records the child PID into Session.spawned_pids so refresh_slots
matches the resulting window via the process-tree walk (Item 3).
* New IPC verb "list-games": returns the joined names so the GUI
can populate the dropdown without a second command.
* launch_game function: tokio::process::Command-equivalent
std::process::Command spawn, child PID captured via child.id(),
dropped (OS keeps the process running; spawned_pids is the
only thing we need).
- examples/games.yaml: shipped with an empty `games: []` plus a
commented-out WoW example so operators have a starting point.
cargo test 103/103 (3 new games tests + the 100 from earlier);
clippy clean.
